Add numerical representation of Consul health check state. #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I targeted this to |
|
this looks good, but I think these should be integers rather than floats |
|
I thought I'd have to do |
|
I would have thought so too, but this line-protocol shows they are floats: |
|
oh ha. Yeah, I just manually typed that. I'll verify and update according. :) |
|
Updated. |
sparrc
reviewed
Jan 25, 2017
| > consul_health_checks,host=wolfpit,node=consul-server-node,check_id="serfHealth" check_name="Serf Health Status",service_id="",status="passing" 1464698464486439902 | ||
| > consul_health_checks,host=wolfpit,node=consul-server-node,service_name=www.example.com,check_id="service:www-example-com.test01" check_name="Service 'www.example.com' check",service_id="www-example-com.test01",status="critical" 1464698464486519036 | ||
| > consul_health_checks,host=wolfpit,node=consul-server-node,check_id="serfHealth" check_name="Serf Health Status",service_id="",status="passing",passing=1i,critical=0i,warning=0i 1464698464486439902 | ||
| > consul_health_checks,host=wolfpit,node=consul-server-node,service_name=www.example.com,check_id="service:www-example-com.test01" check_name="Service 'www.example.com' check",service_id="www-example-com.test01",status="critical",passing=0i,critical=1i,warning-0i 1464698464486519036 |
There was a problem hiding this comment.
sp: warning-0i, still manually typing? ;-)
There was a problem hiding this comment.
You caught me. 😈
Fixed.
|
👍, just update the changelog and I'll merge |
|
Update the changelog and rebased. |
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: