-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Windows CORE Issue #2017
Conversation
902a286
to
d7356b6
Compare
thanks @JeffAshton, can you change docs/LICENSE_OF_DEPENDENCIES as well? |
@sparrc : Docs have been updated Cameron. Thanks for Telegraf. :) |
a3122ea
to
6c212f4
Compare
No problem, I looked into your fork and noticed that it only represents ~400 lines of code. Could you actually just copy and paste that code directly here into a file within the same package as the plugin? For a dependency that small I prefer to just have it in-repo. You can keep the license of the code the same, and paste it in here as well if you want. |
77bc679
to
2fe52d8
Compare
Hey @sparrc, I brought in the pdh library and appended the license and authors. I think that should cover us legally. |
@sparrc, Is there anything else you need from me on this one? |
2fe52d8
to
787a669
Compare
bfd3c54
to
a55a33b
Compare
a55a33b
to
df721f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for leaving this hanging for a while. Looks like it needs to be rebased and then I can merge for 1.2.
df721f0
to
28f2360
Compare
Hey @sparrc , I've rebased the changes. Not sure why a CI build didn't kick off. Can you kick one off for me? Thanks |
Switching from github.com/lxn/win to github.com/JeffAshton/win_pdh. This is a fork of the original library, but containing only the performance counters wrappers.