Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Windows CORE Issue #2017

Closed
wants to merge 1 commit into from

Conversation

JeffAshton
Copy link
Contributor

Switching from github.com/lxn/win to github.com/JeffAshton/win_pdh. This is a fork of the original library, but containing only the performance counters wrappers.

@sparrc
Copy link
Contributor

sparrc commented Nov 9, 2016

thanks @JeffAshton, can you change docs/LICENSE_OF_DEPENDENCIES as well?

@JeffAshton
Copy link
Contributor Author

@sparrc : Docs have been updated Cameron. Thanks for Telegraf. :)

@sparrc
Copy link
Contributor

sparrc commented Nov 9, 2016

No problem, I looked into your fork and noticed that it only represents ~400 lines of code. Could you actually just copy and paste that code directly here into a file within the same package as the plugin? For a dependency that small I prefer to just have it in-repo.

You can keep the license of the code the same, and paste it in here as well if you want.

@JeffAshton JeffAshton force-pushed the issue_1763_win_pdh branch 3 times, most recently from 77bc679 to 2fe52d8 Compare November 9, 2016 18:43
@JeffAshton
Copy link
Contributor Author

Hey @sparrc, I brought in the pdh library and appended the license and authors. I think that should cover us legally.

@sparrc sparrc added platform/windows bug unexpected problem or unintended behavior labels Nov 9, 2016
@JeffAshton
Copy link
Contributor Author

@sparrc, Is there anything else you need from me on this one?

Copy link
Contributor

@sparrc sparrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for leaving this hanging for a while. Looks like it needs to be rebased and then I can merge for 1.2.

@JeffAshton
Copy link
Contributor Author

Hey @sparrc , I've rebased the changes. Not sure why a CI build didn't kick off. Can you kick one off for me? Thanks

sparrc pushed a commit that referenced this pull request Dec 20, 2016
@sparrc
Copy link
Contributor

sparrc commented Dec 20, 2016

we had a configuration issue with CircleCI that had builds from forks disabled. I've created a separate PR (#2180) to merge this change and close #1763

njwhite pushed a commit to njwhite/telegraf that referenced this pull request Jan 31, 2017
@JeffAshton JeffAshton deleted the issue_1763_win_pdh branch February 20, 2017 03:46
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior platform/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants