Use mysql.ParseDSN func instead of url.Parse #1891

sparrc · 2016-10-12T11:46:07Z

Required for all PRs:

CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
Sign CLA (if not already signed)
README.md updated (if adding a new plugin)

closes #870
closes #1842

sparrc · 2016-10-12T14:11:04Z

@maksadbek can you review please?

dgnorton · 2016-10-12T15:55:49Z

👍 lgtm

The MySQL DB driver has it's own DSN parsing function. Previously we were using the url.Parse function, but this causes problems because a valid MySQL DSN can be an invalid http URL, namely when using some special characters in the password. This change uses the MySQL DB driver's builtin ParseDSN function and applies a timeout parameter natively via that. Another benefit of this change is that we fail earlier if given an invalid MySQL DSN. closes #870 closes #1842

sparrc force-pushed the cs870 branch 2 times, most recently from 7026f54 to 245ba5a Compare October 12, 2016 12:06

maksadbek approved these changes Oct 12, 2016

View reviewed changes

sparrc force-pushed the cs870 branch from 245ba5a to a65447d Compare October 12, 2016 16:10

sparrc merged commit a65447d into master Oct 12, 2016

sparrc deleted the cs870 branch October 12, 2016 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use mysql.ParseDSN func instead of url.Parse #1891

Use mysql.ParseDSN func instead of url.Parse #1891

sparrc commented Oct 12, 2016 •

edited

Loading

sparrc commented Oct 12, 2016

dgnorton commented Oct 12, 2016

Use mysql.ParseDSN func instead of url.Parse #1891

Use mysql.ParseDSN func instead of url.Parse #1891

Conversation

sparrc commented Oct 12, 2016 • edited Loading

Required for all PRs:

sparrc commented Oct 12, 2016

dgnorton commented Oct 12, 2016

sparrc commented Oct 12, 2016 •

edited

Loading