Use rfc3339 timestamps in telegraf log output #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
reviewed
Oct 11, 2016
| @@ -30,6 +31,7 @@ func (t *telegrafLog) Write(p []byte) (n int, err error) { | |||
| // interpreted as stdout. If there is an error opening the file the | |||
| // logger will fallback to stdout. | |||
| func SetupLogging(debug, quiet bool, logfile string) { | |||
| log.SetFlags(0) | |||
There was a problem hiding this comment.
Should this only unset the date flag, instead of clearing all flags?
There was a problem hiding this comment.
the flags all deal with prefixes to the logging output, either controlling timestamp formatting or for printing the line-number that the log came from. I don't plan on supporting any of those at the moment, but we could fairly easily add support in the future.
sparrc
force-pushed
the
cs1564
branch
2 times, most recently
from
199fd45 to
317a464
Compare
closes #1564 also add unit and benchmark tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
closes #1564