Log to systemd journal #1732
Closed
Log to systemd journal #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's align to InfluxDB 1.0 logging policy and log to systemd journal by default.
sparrc
approved these changes
Oct 6, 2016
sparrc
pushed a commit
that referenced
this pull request
Oct 6, 2016
Let's align to InfluxDB 1.0 logging policy and log to systemd journal by default. closes #1732
ghost
deleted the
jackzampolin
pushed a commit
that referenced
this pull request
Oct 7, 2016
Let's align to InfluxDB 1.0 logging policy and log to systemd journal by default. closes #1732
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Let's align to InfluxDB 1.0 logging policy and log to systemd journal by
default. See influxdata/influxdb#6839 for more information.
I know there have been several discussions about this for Influx and for Telegraf. I will not debate about pros and cons : systemd is flexible enough to let users choose between a file and journald.
This is just about consistency.
Please kindly review the change with ExecStart. I am not sure about the need to have /bin/sh -c "exec ..."
Thank you very much in advance.
Cheers.