Defines GOOS and GOARCH for windows builds #1621
Conversation
|
if there are packages missing then use the latest |
| @@ -16,7 +16,7 @@ build: | |||
| go install -ldflags "-X main.version=$(VERSION)" ./... | |||
|
|
|||
| build-windows: | |||
| go build -o telegraf.exe -ldflags \ | |||
| GOOS=windows GOARCH=386 go build -o telegraf.exe -ldflags \ | |||
There was a problem hiding this comment.
I'd prefer if we default to amd64 unless there is a significant reason not to
There was a problem hiding this comment.
I derived the value 386 from /scripts/build.py.
On Wed, Aug 10, 2016, 2:58 PM Cameron Sparr [email protected]
wrote:
In Makefile
#1621 (comment):@@ -16,7 +16,7 @@ build:
go install -ldflags "-X main.version=$(VERSION)" ./...build-windows:
- go build -o telegraf.exe -ldflags \
- GOOS=windows GOARCH=386 go build -o telegraf.exe -ldflags \
why 386? are windows servers still 32-bit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/telegraf/pull/1621/files/3115d751b00c6bdabc3795f5f71c9dac918093c3#r74339009,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGK3xw1rzcOgpCDOic7QjOHhikFvE_tks5qekmMgaJpZM4Jhf2Q
.
|
@sparrc Updated per your feedback; thanks! |
|
thx @politician |
|
Unfortunately it's not possible to build telegraf under windows using Gnu makefile. Defining env before command is not supported. |
|
Correct, this change merely enables us to build telegraf for (not on) On Mon, Sep 5, 2016, 9:32 AM Mariusz Brzeski [email protected]
|
|
But it would be great to have also possibility to build it on windows platform :( |
Partial solution for issue #1619. Unfortunately, I can't fix the
gdmissue, because I don't know which revisions of the missing packages to use.Required for all PRs: