Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Allow grouping across register types #16040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 18, 2024

Summary

Currently, each output of a request has the register-type added as a tag, this prevents grouping across register types. However such a grouping across register types might be helpful especially for the metric configuration-style.

This PR adds a exclude_register_type_tag option which is false by default to keep the current behavior. However, for the request and metric configuration-style this allows to group request outputs across register-types by setting it to true.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16031

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 18, 2024
@srebhan srebhan self-assigned this Oct 18, 2024
@telegraf-tiger
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.modbus] Group coil/discrete/holding/input metric together
1 participant