Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump upgrade github.com/shirou/gopsutil from v3.24.4 to v4.24.9 #16023

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

zmyzheng
Copy link
Contributor

@zmyzheng zmyzheng commented Oct 14, 2024

Summary

Telegraf depends on gopsutil to retrieve system related metrics. However, the v3 version is no longer maintained, while the v4 version has new fixes, improves and better platform coverages.

This PR upgrades gopsutil from v3 to v4.

I have tested these plugins using gopsutil and haven't seen any issue from this upgrade so far.

Note: the only breaking changes from v3 to v4 that affects this repo is, host/SensorsTemperatures() moved to in the new sensors package. This PR makes the corresponding change to the input.temp plugin to use the new package to retrieve the tempature by calling sesors.SensorsTemperatures() instead

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16017

@telegraf-tiger telegraf-tiger bot added the chore label Oct 14, 2024
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 15, 2024
@srebhan srebhan changed the title chore(deps): Bump upgrade github.com/shirou/gopsutil from v3 to v4 chore(deps): Bump upgrade github.com/shirou/gopsutil from v3.24.4 to v4.24.9 Oct 15, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zmyzheng for your contribution! In the past we had issues when bumping gopsutils so let's hope this goes smooth this time. ;-)

@srebhan srebhan added the dependencies Pull requests that update a dependency file label Oct 15, 2024
@srebhan srebhan merged commit 67f655b into influxdata:master Oct 15, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 15, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to use v4 of gopsutil as v3 is no longer maintained
3 participants