Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): Add metric disk buffer #15564

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

DStrand1
Copy link
Member

Summary

Implements the write-through buffer persistence strategy detailed in the spec added in #14928.

Checklist

  • No AI generated code was used in this PR

Related issues

Related to #802, #14805
Continuation of #15545
Supersedes #15221

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 25, 2024
@DStrand1 DStrand1 changed the title feat: metric disk buffer feat(agent): metric disk buffer Jun 25, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, some initial comments reading through this.

models/buffer_disk_test.go Outdated Show resolved Hide resolved
models/buffer_disk_test.go Outdated Show resolved Hide resolved
models/buffer_disk_test.go Outdated Show resolved Hide resolved
models/buffer_disk.go Outdated Show resolved Hide resolved
@srebhan srebhan changed the title feat(agent): metric disk buffer feat(agent): Add metric disk buffer Jul 12, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and nice work @DStrand1! I have two questions...

models/buffer_disk.go Outdated Show resolved Hide resolved
models/buffer_disk.go Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -3.11 % for linux amd64 (new size: 243.9 MB, nightly size 251.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the epic work @DStrand1!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2024
@srebhan srebhan removed their assignment Jul 17, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the continued effort on this! There are areas I think we should continue to enhance, but we can do that in follow-ups before the release.

@powersj powersj merged commit 7245ea9 into influxdata:master Jul 17, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 17, 2024
@DStrand1 DStrand1 deleted the agent/disk-buffer branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants