Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs.elasticsearch): Allow settings extra headers for elasticsearch output #15477

Merged
merged 1 commit into from
Jun 10, 2024
Merged

feat(outputs.elasticsearch): Allow settings extra headers for elasticsearch output #15477

merged 1 commit into from
Jun 10, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

Summary

Allow settings extra headers for elasticsearch output's client

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15476

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 8, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@AndrewChubatiuk
Copy link
Contributor Author

!signed-cla

@AndrewChubatiuk AndrewChubatiuk changed the title allow settings extra headers for elasticsearch output feat(outputs.elasticsearch): Allow settings extra headers for elasticsearch output Jun 8, 2024
@telegraf-tiger telegraf-tiger bot added area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 8, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the allow-settings-custom-headers-for-elasticsearch branch 2 times, most recently from 36bd379 to 043e20a Compare June 8, 2024 12:25
@AndrewChubatiuk AndrewChubatiuk mentioned this pull request Jun 8, 2024
Closed
@AndrewChubatiuk AndrewChubatiuk force-pushed the allow-settings-custom-headers-for-elasticsearch branch from 043e20a to fab22b2 Compare June 8, 2024 12:28
srebhan
srebhan reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewChubatiuk thanks for your contribution! The code looks good, just one naming suggestion from my side...

plugins/outputs/elasticsearch/README.md Outdated
Comment on lines 329 to 330
# [outputs.elasticsearch.extra_headers]
# "X-Custom-Header" = "custom-value"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name this just headers please? I don't see where this is "extra"...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just updated

@srebhan srebhan self-assigned this Jun 10, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the allow-settings-custom-headers-for-elasticsearch branch from fab22b2 to 1678da6 Compare June 10, 2024 12:33
@AndrewChubatiuk AndrewChubatiuk force-pushed the allow-settings-custom-headers-for-elasticsearch branch from 1678da6 to 56fd624 Compare June 10, 2024 12:34
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

powersj
powersj approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm grabbing this for the release. Sven's comment was resolved so considering this approved.

@powersj powersj merged commit fe092f6 into influxdata:master Jun 10, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Jun 10, 2024
@AndrewChubatiuk AndrewChubatiuk deleted the allow-settings-custom-headers-for-elasticsearch branch June 10, 2024 13:44
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan left review comments

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

Allow setting custom http headers for elasticsearch output
3 participants
@AndrewChubatiuk @powersj @srebhan