feat(outputs.mqtt): Add client trace logging, resolve MQTT5 reconnect login #15429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
area/mqtt
feat
powersj
added
the
ready for final review
powersj
changed the title
the full string for reconnects.
DStrand1
approved these changes
Jun 5, 2024
srebhan
approved these changes
Jun 5, 2024
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Jul 26, 2024
In influxdata#15429, I added trace logging to the mqtt outputs for v3 and v5. I removed trace logging settings from the input, moving it to the common code. However, the input does not even use the common code *facepalm*. This restores the trace option for the input.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a more generic MQTT client trace logging that also applies to the output. It adds logging when using the MQTT5 client. Additionally, with the help of this logging it resolves an issue where the reconnect attempts on the MQTT5 client where the username and password were destroyed and unable to be re-used later on.
Checklist
Related issues
fixes: #15418