-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent): Warn on multple agent configuration tables seen #15402
fix(agent): Warn on multple agent configuration tables seen #15402
Conversation
Isn't that doing just a merge of the 2? I see no issue in having these configs: [agent]
interval = "30s" [agent]
debug = true |
Yes, your hand-crafted, limited example would not present any issues. It however gives the appearance that you can have multiple independent agent definitions, which is simply not true. |
Sure, but I don't agree to "eventually error on these type of issues". I do have a valid use case to have multiple agent sections. I agree to throw warnings or error out if those sections have overlapping parameters/items. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Users sometimes try to use multiple agent sections, but this leads to undefined behavior. We should start to warn and eventually error on these types of issues.
Checklist