Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.gnmi): Allow to pass accepted cipher suites #15256

Merged
merged 9 commits into from
May 6, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 29, 2024

Summary

In grpc-go v1.60.0 insecure cipher-suites were disabled by default. As some devices might still require those, this PR adds the possibility to explicitly set accepted ciphers using the
tls_cipher_suites setting for client TLS.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15236

@telegraf-tiger telegraf-tiger bot added area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 29, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 29, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Couple doc questions

plugins/inputs/gnmi/sample.conf.in Show resolved Hide resolved
plugins/common/tls/client.conf Outdated Show resolved Hide resolved
@srebhan srebhan requested a review from powersj April 30, 2024 16:04
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj removed their assignment Apr 30, 2024
@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 May 6, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 6, 2024

@srebhan srebhan merged commit 46fb0af into influxdata:master May 6, 2024
27 checks passed
@srebhan srebhan deleted the gnmi_issue_15236 branch May 6, 2024 18:19
@github-actions github-actions bot added this to the v1.31.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.gnmi: Authentication Broken starting in 1.29.2
3 participants