Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.gnmi): Add yang-model decoding of JSON IETF payloads #15201

Merged
merged 11 commits into from
May 23, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 22, 2024

Summary

This PR adds decoding of JSON IETF payloads according to the YANG model for non-standard base-types.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15046

@telegraf-tiger telegraf-tiger bot added area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 22, 2024
@srebhan srebhan self-assigned this Apr 22, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 17, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan May 17, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I feel more confident about it given the actual testing done by the user.

@powersj powersj removed their assignment May 20, 2024
@srebhan srebhan requested a review from powersj May 21, 2024 09:35
@srebhan
Copy link
Member Author

srebhan commented May 21, 2024

@powersj I simplified the leaf lookup a bit more and off-loaded namespace-module mapping to the init-phase...

@telegraf-tiger
Copy link
Contributor

@DStrand1 DStrand1 merged commit 4aa288b into influxdata:master May 23, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GNMI Plugin] Support for processing Base64 Encoded Binary Data
3 participants