Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.http_response): Add cookie authentication #15110

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

DStrand1
Copy link
Member

@DStrand1 DStrand1 commented Apr 4, 2024

Summary

Add http cookie auth to the http_response input plugin, similar to the http input plugin

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #11913

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 4, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 5, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Did you ask the reporter to try this out? If not I would.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @DStrand1! Thanks!

@srebhan srebhan changed the title feat(inputs.http_response): add cookie auth feat(inputs.http_response): Add cookie authentication Apr 8, 2024
@srebhan srebhan removed their assignment Apr 8, 2024
@srebhan
Copy link
Member

srebhan commented Apr 8, 2024

@powersj assigning it back to you in case you want to test it some more...

@powersj powersj assigned DStrand1 and unassigned powersj Apr 10, 2024
@DStrand1
Copy link
Member Author

@Space2Man Are you available to test this fix for your issue #11913? Thanks in advance!

@DStrand1 DStrand1 merged commit 43687b4 into influxdata:master Apr 15, 2024
27 checks passed
@DStrand1 DStrand1 deleted the fix-11913 branch April 15, 2024 21:47
@github-actions github-actions bot added this to the v1.31.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow cookie auth also in http_response plugin (like in http input plugin)
3 participants