feat(inputs.intel_powerstat): Extract business logic to external library

[ggalieroc]

Summary

The Intel PowerStat plugin has recently expanded significantly, primarily due to the sophisticated domain logic required to read various metrics from a variety of processor models.
In order to simplify and enhance the readability of the plugin, we (Intel) have extracted most of the mentioned logic into an external (and publicly accessible) library at https://github.com/intel/powertelemetry.
We would like to add this library as a dependency and utilize it in this plugin for metric reading purposes.

This PR also introduces new features:

• New cpu metrics: cpu_c0_substate_c01_percent, cpu_c0_substate_c02_percent and cpu_c0_substate_c0_wait_percent added (based on kernel's perf interface, currently available only for Intel Sapphire Rapids X and Intel Emerald Rapids X).
• For kernel version >= 5.18 uncore_frequency_mhz_cur metric is exposed via intel-uncore-frequency kernel module and will be read from there. For older kernels, it is still accessed via msr kernel module.
• included_cpus and excluded_cpus configuration fields are introduced - to gather cpu_metrics only from configured cpus.
• msr_read_timeout configuration field added - to set the optional timeout duration for MSR reading.

Checklist

• No AI generated code was used in this PR

Related issues

Also this PR:

• fixes Incorrect package power consumption from intel_powerstat #14109
• fixes intel_powerstat: telegraf hangs after some time running on a stressed preempt-rt system #14088 (and supersedes fix(inputs.intel_powerstat): Add MSR read timeout (#14088) #14089)
• expands the list of processor models supporting the uncore_frequency metrics mentioned in Metrics missing from intel_powerstat #13098 (and implemented in docs(inputs.intel_powerstat): Add notes about hw/sw dependencies #14263)

[srebhan]

Thanks for your contribution and the nice cleanup of this plugin @ggalieroc! I do have some comments...

[ggalieroc]

Thanks for your contribution and the nice cleanup of this plugin @ggalieroc! I do have some comments...

Thank you for your review comments!. I have replied to them. Please allow me some time to add fixes.

[ggalieroc]

Thanks for your feedback @Hipska and @srebhan. I have addressed your comments and would appreciate another round of reviews.

[Hipska]

Great improvements, only minor comments..

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[ggalieroc]

Hi @srebhan, I addressed your comments, :). If you could please have a look would be great.

[srebhan]

Thanks for all your work @ggalieroc and thanks for the valuable input @p-zak!

[powersj]

Thanks for putting this up.

I think we are all in agreement that in future PRs we would like to see the tests pull data from test files like we do in other plugins. I would also love to see smaller PRs ;) There is no way that any of us were able to thoroughly and confidently review 11k+ lines.