Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(outputs.bigquery): Allow to add metrics in one compact table #14342

Merged
merged 12 commits into from
Dec 4, 2023
Merged

feat(outputs.bigquery): Allow to add metrics in one compact table #14342

merged 12 commits into from
Dec 4, 2023

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Nov 24, 2023 •
edited
Loading

Required for all PRs

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Nov 24, 2023
@Hipska Hipska added the area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver label Nov 24, 2023
@Hipska Hipska force-pushed the feat/outputs/bigquery_compact branch from 14c043b to 7f45222 Compare November 24, 2023 16:16
@Hipska Hipska marked this pull request as ready for review November 27, 2023 16:42
srebhan
srebhan reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature @Hipska! A few comments/questions from my side...

plugins/outputs/bigquery/bigquery.go Outdated Show resolved Hide resolved
plugins/outputs/bigquery/bigquery.go Outdated Show resolved Hide resolved
plugins/outputs/bigquery/bigquery.go Outdated Show resolved Hide resolved
plugins/outputs/bigquery/sample.conf Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Nov 29, 2023
@Hipska Hipska requested a review from srebhan November 30, 2023 11:50
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska for the update! I would love to see a comment regarding the inserter because whenever I come across it I think "that might be dangerous". So a comment would show that you checked the matter.

plugins/outputs/bigquery/bigquery.go Show resolved Hide resolved
plugins/outputs/bigquery/bigquery.go Outdated Show resolved Hide resolved
@Hipska Hipska requested a review from srebhan December 4, 2023 09:45
@Hipska

This comment was marked as resolved.

Sign in to view
srebhan
srebhan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the PR @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 4, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Dec 4, 2023
@srebhan srebhan changed the title feat(outputs.bigquery): Add option to add metrics in one compact table feat(outputs.bigquery): Allow to add metrics in one compact table Dec 4, 2023
@powersj powersj merged commit 6ff28c7 into influxdata:master Dec 4, 2023
22 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 4, 2023
@Hipska Hipska deleted the feat/outputs/bigquery_compact branch December 4, 2023 14:43
@Porkepix Porkepix mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hipska @powersj @srebhan