-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sql): Add support for IBM Netezza #14200
Conversation
Thanks so much for the pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the PR. One small comment below, however the 32-bit build failures are the larger concern. I see you commented on IBM/nzgo#38
What is your plan to resolve the 32-bit build issues? |
I'm going to talk to IBM on Monday about that. It may take some time for this issue to become fixed. |
Just as a hint: As workaround you could guard the driver with build-tags excluding 32-bit archs (similar to sqlite)... |
Thanks for suggestion @srebhan |
Looks like IBM/nzgo#60 was landed. Is an update to the version imported all that is required? |
@powersj My PR with support for 32-bit envs for nzgo was indeed merged, but a new version of this driver has not yet been released. I'm in touch with the maintainers and waiting for their decision about when to release it. |
They haven't seem to have tagged a release in 2 years. Our next feature release is in a few weeks and I would like to see this land in that, instead of waiting till March. What we can do is import the repo at a specific commit, rather than a specific tag/release. Then if/when they do an actual release we can switch the go.mod entry to a commit hash. |
@mplpl I have checked out your branch, rebased on our master, updated it to use nzgo with the master branch from today, and run go mod tidy. |
@powersj ok, thanks. It is Diwali holiday in India, and the person responsible for nzgo is away now. But she should be back in a few days and promised to update me with when they plan to tag a new version. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add integration test like we have for others? Or would that not be easy to achieve?
@Hipska I don't see any official container image, so having an integration test would be hard... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @mplpl! Feel free to bump the driver once a new release is out.
Required for all PRs
Added support for IBM Netezza data warehouse to inputs/sql plugin.