Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.bigquery): Project is no longer a required field #14086

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Oct 10, 2023

Required for all PRs

This is a preparation for a bigger rewrite of the BigQuery plugin.

The provided credentials file has the project name as well, so the library will try to auto-detect it from the file. There is also no backwards compatibility breakage, as the parameter was a required field before.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 10, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Hipska! Two small questions...

plugins/outputs/bigquery/bigquery.go Show resolved Hide resolved
plugins/outputs/bigquery/sample.conf Outdated Show resolved Hide resolved
@srebhan
Copy link
Member

srebhan commented Oct 10, 2023

@Hipska there is also a dependency license-entry missing...

@srebhan srebhan self-assigned this Oct 10, 2023
@Hipska Hipska force-pushed the feat/outputs/bigquery/cleanup branch from 1f10e3e to 2bec266 Compare October 10, 2023 15:50
@Hipska
Copy link
Contributor Author

Hipska commented Oct 10, 2023

My local checker asked for another dependency to be added, but CircleCI didn't, so I removed it again.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 11, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Oct 11, 2023
@powersj powersj added the waiting for response waiting for response from contributor label Oct 12, 2023
@telegraf-tiger
Copy link
Contributor

@Hipska Hipska removed the waiting for response waiting for response from contributor label Oct 16, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@powersj powersj merged commit 74937de into influxdata:master Oct 16, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 16, 2023
@Hipska Hipska deleted the feat/outputs/bigquery/cleanup branch October 27, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants