-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.bigquery): Project is no longer a required field #14086
feat(outputs.bigquery): Project is no longer a required field #14086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Hipska! Two small questions...
@Hipska there is also a dependency license-entry missing... |
1f10e3e
to
2bec266
Compare
My local checker asked for another dependency to be added, but CircleCI didn't, so I removed it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort @Hipska!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Required for all PRs
This is a preparation for a bigger rewrite of the BigQuery plugin.
The provided credentials file has the project name as well, so the library will try to auto-detect it from the file. There is also no backwards compatibility breakage, as the parameter was a required field before.