Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.win_service): Reduce required rights to GENERIC_READ #14073

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 9, 2023

resolves #13382

This PR tries to reduce the requested-rights to a minimum for gathering the service information. With the PR we request GENERIC_READ which cannot modify the services. There might be room for trimming this down further if there is need...

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 9, 2023
@srebhan srebhan added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label Oct 9, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 11, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - Thanks!

Ran this locally as admin and as a user and compared it to the existing nightly. It definitely did pull more services, so users may see even more metrics.

@powersj powersj merged commit 2a6b16e into influxdata:master Oct 16, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.win_services] could not open service - Error for services with restricted priviledges
3 participants