Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.kube_inventory): Support using kubelet to get pods data #13996

Merged
merged 20 commits into from
Oct 4, 2023

Conversation

Noy-Simon
Copy link
Contributor

resolves #13878
superseeds #13893

Add an option to get pods info using Kubelet to avoid high loads on the API server on large clusters

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 26, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature @Noy-Simon! Some comments in the code...

plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
plugins/inputs/kube_inventory/pod.go Outdated Show resolved Hide resolved
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one simplification, otherwise the code looks good. Thanks @Noy-Simon!

plugins/inputs/kube_inventory/kube_inventory.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Sep 28, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Noy-Simon!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Oct 2, 2023
@Noy-Simon Noy-Simon requested a review from powersj October 4, 2023 10:56
@powersj
Copy link
Contributor

powersj commented Oct 4, 2023

@Noy-Simon - I merged your other PR now we have conflicts, can you rebase this on master to get a fix for Windows CI and resolve the conflicts? Then I can merge this!

Thanks

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 4, 2023

@Noy-Simon
Copy link
Contributor Author

Hey @powersj i fixed the conflicts but it looks like the test integration fails in all of the branches

@powersj
Copy link
Contributor

powersj commented Oct 4, 2023

it looks like the test integration fails in all of the branches

That's fine I have #14051 to fix that.

@powersj powersj merged commit f8a5a17 into influxdata:master Oct 4, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 4, 2023
@Noy-Simon Noy-Simon deleted the use_kubelet_to_get_pods branch October 4, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/k8s feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter kuberetes_inventory input plugin nodes and pods by node name
3 participants