-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.kube_inventory): Support using kubelet to get pods data #13996
Conversation
Co-authored-by: Sven Rebhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice feature @Noy-Simon! Some comments in the code...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one simplification, otherwise the code looks good. Thanks @Noy-Simon!
Co-authored-by: Sven Rebhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @Noy-Simon!
@Noy-Simon - I merged your other PR now we have conflicts, can you rebase this on master to get a fix for Windows CI and resolve the conflicts? Then I can merge this! Thanks |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Hey @powersj i fixed the conflicts but it looks like the test integration fails in all of the branches |
That's fine I have #14051 to fix that. |
resolves #13878
superseeds #13893
Add an option to get pods info using Kubelet to avoid high loads on the API server on large clusters