Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs): Add LDAP input plugin supporting OpenLDAP and 389ds #13995

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Sep 26, 2023

This is a now plugin that superseeds the OpenLDAP plugin. It generalizes the metric gathering and adds support for the 389ds directory server.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 26, 2023
@srebhan srebhan added new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Sep 26, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this as well!

One typo in sample config, I think?

Can you highlight what a user, using the existing openldap would need to do to switch over? Other than the switch from a host/port to server parameter, is there anything else? Are the metrics identical otherwise?

plugins/inputs/ldap/README.md Outdated Show resolved Hide resolved
@dburton-influxdata
Copy link

Would the customer be able to just download the Nightly builds published on our Release site to test? - https://portal.influxdata.com/downloads/

They are willing to test and I am working to see how I can get them the test build.

@powersj
Copy link
Contributor

powersj commented Sep 27, 2023

@dburton-influxdata there are artifacts available in the comment above by the telegraf-tiger (direct link). If they click the little box icon it will expand to provide even more downloads.

I would prefer that we get confirmation from the customer before landing this in master.

Thanks!

@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I'll be out, but please wait to land until we hear back from a user.

@powersj powersj assigned srebhan and unassigned powersj Oct 3, 2023
@srebhan
Copy link
Member Author

srebhan commented Oct 10, 2023

Merging after positive feedback from the user...

@srebhan srebhan merged commit 0c1e213 into influxdata:master Oct 10, 2023
4 checks passed
@srebhan srebhan deleted the ldap_input branch October 10, 2023 11:09
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants