-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Amazon Linux distribution in post remove scripts #1381
Conversation
I'm not sure that you've handed all cases here. What if the script is called in "upgrade" mode on amazon linux? Why are you not detecting that? (see relevant if-statements for debian and rpm) |
Thanks for review and feedback @sparrc |
f27da53
to
3321309
Compare
@sparrc - Please review the update and share feedback. Sorry I had to force push as I ran into issue with rebase from upstream. Instead of going by the Linux distribution based conditional branching this revised script handle remove based on what packaging guidelines these distributions follow. |
thnaks @schebrolu |
@schebrolu can you rebase your changes and re-push. Force pushing is totally fine, by the way. |
Thank you @sparrc |
thanks @schebrolu |
No merge :( |
oops! my mistake |
Required for all PRs: