-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.upsd): handle battery.runtime as float value #13412
fix(inputs.upsd): handle battery.runtime as float value #13412
Conversation
Thanks so much for the pull request! |
!signed-cla |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the fix @danclough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Required for all PRs
In the upsd input plugin, fixed handling of battery.runtime value to account for possible float values. Some UPS systems (APC SmartUPS) may present battery.runtime as a float value like 1000.00, which causes the int64 casting in the plugin to fail.
This merge request reads the battery.runtime value as a float64, multiplies it to nanoseconds, and then casts the result back to int64 to remain compatible with the previous implementation.