fix(internal): Fix time parsing for abbreviated timezones #13363
Conversation
srebhan
added
the
ready for final review
|
After a short discussion, we concluded to make the change in behavior more visible. @powersj does the warning and Changelog text work for you? |
internal/internal.go
Outdated
| once.Do(func() { | ||
| log.Print("W! You are using abbreviated timezones for which parsing was fixed in v1.27.0.") | ||
| log.Print("W! Please remove any workarounds in place and check your resulting times carefully!") | ||
| log.Print("W! In case you experience any problems, please file an issue!") |
There was a problem hiding this comment.
| log.Print("W! In case you experience any problems, please file an issue!") | |
| log.Print("W! If you experience any problems, please file an issue on GitHub") |
There was a problem hiding this comment.
IMHO this line can be removed, this counts for any problem experienced, not only for timezones.
There was a problem hiding this comment.
@Hipska I like to encourage people to report the stuff, so the line is well spend IMO. This worked quite well for the gnmi plugin...
There was a problem hiding this comment.
Okay, but there it is in a single log message, not spread over multiple independent lines.. Please keep the messages together!
It is now fine as the multiple log messages are now also combined into one.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
resolves #12960
upstream issues golang/go#56528, golang/go#9617
Golang does not handle ambiguous timezones which holds true for almost all abbreviated timezones. As a workaround, (see Golang discussion) we can parse times with abbreviated timezones first to get the timezone's name and then forcefully parse the time-string in the found timezone. By doing this we can handle many of the abbreviated timezones correctly assuming the "most probable" of the ambiguous timezone abbreviations, e.g. "Mountain Standard Time" for "MST".