-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sql): Add 'disconnected_servers_behavior' field in the configuration #13289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I have put some thoughts/questions below. My main purpose of the changes is to ensure the logic is as streamlined as possible should we add additional retry logic in the future.
Co-authored-by: Joshua Powers <[email protected]>
Thanks for reviewing. I agree with all of your suggestions, it makes sense that prepareStatements doesnt need to check for I was experimenting with preparedStatments, and in fact I found that we dont even need to ping the server. The |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the nice feature @neelayu!
Required for all PRs
resolves #13282