-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore disabled uint support by default #13164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this @powersj. One question though...
plugins/outputs/influxdb/influxdb.go
Outdated
@@ -169,7 +169,7 @@ func (i *InfluxDB) Write(metrics []telegraf.Metric) error { | |||
} | |||
|
|||
func (i *InfluxDB) udpClient(address *url.URL) (Client, error) { | |||
serializer := &influx.Serializer{UintSupport: true} | |||
serializer := &influx.Serializer{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
serializer := &influx.Serializer{} | |
serializer := &influx.Serializer{i.InfluxUintSupport} |
as we otherwise now always disable uint-support!? Same for the other instances below...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed - I've pushed a change for the influxdb/influxdb.go
and influxdb_v2/influxdb_v2.go
. @srebhan can you look at the influxdb/udp.go
?
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.