Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support of Juniper GNMI Extension Header in gnmi input plugin #13116

Merged
merged 38 commits into from
Apr 27, 2023
Merged

feat: support of Juniper GNMI Extension Header in gnmi input plugin #13116

merged 38 commits into from
Apr 27, 2023

Conversation

door7302
Copy link
Contributor

Required for all PRs

resolves #13115

This implementation has been tested at scale without any issue, performance impact. Sample output:

{"fields":{"/junos/firewall/state/timestamp":1680619403},"name":"","tags":{"component":"PFE","component_id":"0","host":"rtme-ubuntu-02","name":"DROP_FTF","path":"/junos/firewall/state","source":"rtme-mx-25.englab.juniper.net","sub_component_id":"0"},"timestamp":1681979776}

A specific test case has been developed as well to valide the behavior of this enhancement.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 20, 2023
@door7302 door7302 changed the title feat: support of Juniper GNMI Extension Header in gnmi inmput plugin feat: support of Juniper GNMI Extension Header in gnmi input plugin Apr 20, 2023
powersj
powersj reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to put up a PR! Also happy to hear it is in use :)

I've done a quick first pass, but nothing of major concern I think. Give my comments a look over and we can do a deeper look after updates.

package-lock.json Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
plugins/inputs/gnmi/README.md Outdated Show resolved Hide resolved
plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented Apr 20, 2023

please run go mod tidy and check in changes

For tests to fully run, you will want to ensure you do this as well.

@door7302
Copy link
Contributor Author

!signed-cla

@door7302
Copy link
Contributor Author

I fixed all your comments.

powersj
powersj reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around. I have 3 questions below, but I also pushed two changes to clean things up a little bit, and get tests passing.

plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/handler.go Show resolved Hide resolved
plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
Hipska
Hipska suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, a few minor remarks left..

plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/gnmi_test.go Outdated Show resolved Hide resolved
@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 24, 2023
powersj
powersj approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj assigned srebhan and unassigned powersj Apr 24, 2023
srebhan
srebhan reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature @door7302. I have two small comments...

plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/gnmi.go Show resolved Hide resolved
Hipska
Hipska suggested changes Apr 25, 2023
View reviewed changes
plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
Hipska
Hipska approved these changes Apr 25, 2023
View reviewed changes
plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
@door7302
Copy link
Contributor Author

Chnages have been done.

srebhan
srebhan reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@door7302 thanks for the update! I do have one more comment and recommend to merge the suggestion of @Hipska. With those two resolved I think we are ready to go.

plugins/inputs/gnmi/handler.go Outdated Show resolved Hide resolved
@door7302 @Hipska
Update plugins/inputs/gnmi/gnmi.go
3d40bff 
Co-authored-by: Thomas Casteleyn <[email protected]>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @door7302!

@srebhan srebhan merged commit a868add into influxdata:master Apr 27, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 13, 2023
Merged
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hipska Hipska Hipska approved these changes

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/gnmi area/juniper feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

Support of Juniper Gnmi Extension
4 participants
@door7302 @powersj @Hipska @srebhan