-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.netflow): Add sFlow decoder #13047
Conversation
b96a4a5
to
49bc11c
Compare
@srebhan I know you assigned this to me for a final review, but you do have some test failures ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question in line about the dependency. I'd like to see tests cleaned up and then validation from the user you are working on this with before marking approved.
Thanks!
ok I think then we need tests cleaned up and some feedback from the user. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@srebhan I'm going to assign this to you and let you merge when you are ready. Not sure if you still want to wait for additional feedback from users. |
Let's merge it and adapt it to the feedback once it comes... |
This PR adds a sflow decoder to the netflow plugin.