Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.netflow): Add sFlow decoder #13047

Merged
merged 8 commits into from
Jun 1, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 6, 2023

This PR adds a sflow decoder to the netflow plugin.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 6, 2023
@srebhan srebhan force-pushed the sflow_ear_4090 branch 4 times, most recently from b96a4a5 to 49bc11c Compare April 12, 2023 14:54
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 9, 2023
@srebhan srebhan assigned powersj and unassigned srebhan May 9, 2023
@powersj
Copy link
Contributor

powersj commented May 17, 2023

@srebhan I know you assigned this to me for a final review, but you do have some test failures ;)

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question in line about the dependency. I'd like to see tests cleaned up and then validation from the user you are working on this with before marking approved.

Thanks!

go.mod Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented May 19, 2023

ok I think then we need tests cleaned up and some feedback from the user.

@powersj powersj removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 23, 2023
@powersj powersj assigned srebhan and unassigned powersj May 23, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 30, 2023
@srebhan srebhan assigned powersj and unassigned srebhan May 30, 2023
@powersj
Copy link
Contributor

powersj commented May 31, 2023

@srebhan I'm going to assign this to you and let you merge when you are ready. Not sure if you still want to wait for additional feedback from users.

@powersj powersj assigned srebhan and unassigned powersj May 31, 2023
@srebhan
Copy link
Member Author

srebhan commented Jun 1, 2023

Let's merge it and adapt it to the feedback once it comes...

@srebhan srebhan merged commit 6c49584 into influxdata:master Jun 1, 2023
@srebhan srebhan deleted the sflow_ear_4090 branch June 1, 2023 08:02
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants