fix(secrets): Warn if OS limit for locked memory is too low #12993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
reviewed
Mar 30, 2023
srebhan
force-pushed
the
secret_store_issue_12980
branch
from
c5799cf to
160d800
Compare
powersj
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
ok played with this a bit an created a config with 10x influxdb_v2 outputs each using a secret and reduced the ulimit to 64K:
2023-03-31T14:10:25Z I! Found 10 secrets...
2023-03-31T14:10:25Z W! Insufficient lockable memory 64kb when 80kb is required. Please increase the limit for Telegraf in your Operating System!and after increasing to 80k it did not show up. I had Windows up and all I tested that the binary continued to work.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
ready for final review
srebhan
added a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit d8adb1e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #12980
Plugins using secrets rely on locked memory in Telegraf. Due to limitations in the underlying library, each secret will use two pages of (locked) memory for the access time. Some operating systems or operators set a low limit on the maximum allowed amount of locked memory, making Telegraf hang (see #12924 or #12980) or panic of too many secrets are accessed at the same time. To be on the safe-side, warn the user if the limit set by the OS is too low for the number of secrets managed.