-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.prometheus): control which pod metadata is added as tags #12851
Conversation
0a27750
to
a65f62f
Compare
a65f62f
to
78186ed
Compare
78186ed
to
4079484
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to talk to Sven about this one, but given the wide range of annotations and how we are handling them, this seems like a nice addition.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach. Thanks for adding this feature @redbaron!
resolves #12850
Add
pod_annotation_include
,pod_annotation_exclude
,pod_label_include
,pod_label_exclude
which control how pod metadata is added to the metric tags. Works very much like existingtaginclude
/tagexclude
, but allows better control as they act on pod metadata exclusively.