-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.modbus): Add workaround to enforce reads from zero for coil registers #12408
Conversation
Co-authored-by: Joshua Powers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, obviously it would have been nice to get the reporter to confirm it fixes things though.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
resolves #8905
This PR allows to enforce reading coil-registers starting at zero which is required for some devices (see issue #8905). This replaces a workaround to define all fields between the register you want to read (e.g. 1000) and zero with the omit flag being set to true.