chore: Improve processor ordering #12308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on #12113
PR #12113 improved the processor ordering by keeping the loading order within a file. This PR is a follow-up to make the ordering less intrusive, keeping the
addProcessor()
similar to otheradd...
function and remove the input-file information from the model.This is achieved by sorting the loaded processors by the line number (similar to #12113) within the loaded file and then add the new chunk to the config's processor array. This way, the loading order of the files is also preserved. To also take the
order
option into account the processor array is sorted a second time, this time by theorder
flag using a stable sort. This way all plugins containing anorder
option are sorted by this value, whereas all other plugins will keep their loading order (across files) and specification order (within each file).