fix(inputs.mongodb): actually start plugin correctly #11849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start method handler did not match the interface, nor was there a stop function. As a result, start was never called and the plugin was never setting up the servers to connect to and collect from correctly. This was introduced in influxdata#11629. fixes: influxdata#11830
telegraf-tiger
bot
added
area/mongodb
fix
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
|
Tests all pass! |
powersj
added
the
ready for final review
sspaink
approved these changes
Sep 21, 2022
reimda
approved these changes
Sep 21, 2022
popey
pushed a commit
that referenced
this pull request
Oct 3, 2022
(cherry picked from commit f899eb5)
dba-leshop
pushed a commit
to dba-leshop/telegraf
that referenced
this pull request
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The start method handler did not match the interface, nor was there a
stop function. As a result, start was never called and the plugin was
never setting up the servers to connect to and collect from correctly.
This was introduced in #11629.
fixes: #11830