Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove deprecated settings functionality for output plugins #11748

Closed
wants to merge 6 commits into from

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Aug 31, 2022

DON'T MERGE TO MASTER, the strategy will be to merge all breaking changes to a separate branch.

Remove the deprecated settings for output plugins listed in #9478. Since this breaks compatibility, it will not be merged until the next major release (2.0).

Semantic PR checker is failing because: influxdata/validate-semantic-github-messages#20

@sspaink sspaink added breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 31, 2022
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 31, 2022
@sspaink sspaink changed the title fix(output)!: Remove deprecated settings fix!: Remove deprecated settings for output plugins Aug 31, 2022
@sspaink sspaink changed the title fix!: Remove deprecated settings for output plugins fix: Remove deprecated settings for output plugins Aug 31, 2022
@sspaink sspaink changed the title fix: Remove deprecated settings for output plugins fix!: Remove deprecated settings for output plugins Aug 31, 2022
@Hipska Hipska added this to the 2.0.0 milestone Sep 6, 2022
@sspaink
Copy link
Contributor Author

sspaink commented Sep 12, 2022

TODO: Don't delete settings from struct to maintain deprecation messages

@sspaink sspaink added the 2.0 label Sep 12, 2022
@telegraf-tiger
Copy link
Contributor

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 13, 2022
@sspaink sspaink changed the title fix!: Remove deprecated settings for output plugins fix!: Remove deprecated settings functionality for output plugins Sep 13, 2022
@Hipska Hipska removed the 2.0 label Sep 19, 2022
@sspaink sspaink changed the title fix!: Remove deprecated settings functionality for output plugins fix!: Remove deprecated settings functionality for output plugin Oct 3, 2022
@sspaink sspaink changed the title fix!: Remove deprecated settings functionality for output plugin fix!: Remove deprecated settings functionality for output plugins Oct 3, 2022
@powersj powersj removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 8, 2022
@powersj
Copy link
Contributor

powersj commented Jan 23, 2023

As we are not planning on doing a Telegraf 2.x at this time anymore, I am closing breaking changes issues and PRs. While we have interest in making these improvements we currently, and for the foreseeable future do not have the capital to maintain two major versions while also supporting our users at the same level.

@powersj powersj closed this Jan 23, 2023
@powersj powersj deleted the outputdeprecatedsettings branch January 23, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Improvement to Telegraf that requires changes to the plugin or agent; for minor/major releases fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants