Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add median timing calculation to statsd input plugin #11518

Merged
merged 17 commits into from
Jul 22, 2022
Merged

feat: add median timing calculation to statsd input plugin #11518

merged 17 commits into from
Jul 22, 2022

Conversation

amarinderca
Copy link
Contributor

@amarinderca amarinderca commented Jul 18, 2022 •
edited
Loading

resolves #11517

changes statsd input plugin files by adding tests, readme, median calculation function

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 18, 2022
srebhan
srebhan reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @amarinderca! I have some small comments in the code, can you please have a look!?

plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Jul 19, 2022
@srebhan srebhan added area/statsd plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 19, 2022
srebhan
srebhan reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @amarinderca! I have some more comments...

plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
srebhan
srebhan reviewed Jul 21, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment to make the code a bit more robust. Not a must though as it works this way, but it's not obvious. What do you think?

plugins/inputs/statsd/running_stats.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @amarinderca!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 22, 2022
powersj
powersj approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@powersj powersj merged commit d84bf9a into influxdata:master Jul 22, 2022
@sjwang90 sjwang90 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/statsd feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add median timing calculation to statsd input plugin
3 participants
@amarinderca @powersj @srebhan