-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nats Jetstream consumer #11046 add simple support for jetstream subjects #11373
Conversation
Solve linter errors on pull request
solve linter errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @b3rtram and thanks for the nice contribution! I have some smaller comments in the code. Can you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I'd nevertheless like to ask you for a few more words in the README to help new/inexperienced users to find their way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks @b3rtram!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Required for all PRs:
resolves #11046
Changed nats_consumer input plugin. Added a new configuration element js_subjects where a user can add the subjects to subscribe with jetstream context. If the length of the js_subjects_array is zero it will ignored. js_subject is optional, the original subject is not optional, so there are no breaking changes.
Because there is no interface in go nats consumer I could not reuse nats.Conn, I need to add a new jsConn variable and copy code :(
This is my first github code contribution. Please be patient and give me feedback