Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a starlark example showing how to obtain IOPS (to aggregate, to produce max_iops). #8903

Closed
thatsafunnyname opened this issue Feb 24, 2021 · 2 comments · Fixed by #8996
Closed

Add a starlark example showing how to obtain IOPS (to aggregate, to produce max_iops). #8903

thatsafunnyname opened this issue Feb 24, 2021 · 2 comments · Fixed by #8996
Labels
area/starlark docs Issues related to Telegraf documentation and configuration descriptions feature request Requests for new plugin and for new features to existing plugins

Comments

@thatsafunnyname
Copy link
Contributor

thatsafunnyname commented Feb 24, 2021 •
edited
Loading

Hello and thanks for telegraf,

Proposal:

Review and add a starlark example showing how to obtain IOPS (to aggregate, to produce max_iops).
Where the max_iops is the peak IO per second rate seen over a period (and not a maximum of means of IO "per second").
In my example the period is 60s.

Current behavior:

No example of how to do this (that I could find).

Desired behavior:

An example star file in telegraf/plugins/processors/starlark/testdata/

Use case:

I asked in https://community.influxdata.com/t/can-telegraf-be-used-to-aggregate-max-iops if what I wanted to do was possible or not, and after some guidance to look at the starlark processor was able to get it working.

My goal is to use the max_iops (along with other diskio metrics) when viewing usage of, and provisioning IOPS on disks.

I did spend some time searching the telegraf github project for mention of IOPS, and I think if an example had been present then it would have saved me some time.

I have attached iops.star , if you think a PR for it is appropriate then please let me know.

iops.star.txt

Thanks.
@thatsafunnyname thatsafunnyname added the feature request Requests for new plugin and for new features to existing plugins label Feb 24, 2021
@thatsafunnyname thatsafunnyname mentioned this issue Feb 24, 2021
Merged
3 tasks
@sjwang90
Copy link
Contributor

@thatsafunnyname Can you open a PR with your example like you did for the shared state example?

@sjwang90 sjwang90 added the docs Issues related to Telegraf documentation and configuration descriptions label Mar 16, 2021
thatsafunnyname added a commit to thatsafunnyname/telegraf that referenced this issue Mar 16, 2021
@thatsafunnyname
starlark example showing how to obtain IOPS
3000ab4 
starlark example showing how to obtain IOPS (to aggregate, to produce max_iops)
From influxdata#8903
thatsafunnyname added a commit to thatsafunnyname/telegraf that referenced this issue Mar 16, 2021
@thatsafunnyname
Add iops example.
4747080 
From influxdata#8903 .
How to obtain IOPS (to aggregate, to produce max_iops).
Where the max_iops is the peak IO per second rate seen over a period (and not a maximum of means of IO "per second").
@thatsafunnyname thatsafunnyname mentioned this issue Mar 16, 2021
Merged
@sjwang90
Copy link
Contributor

Closed in #8996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/starlark docs Issues related to Telegraf documentation and configuration descriptions feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a starlark example showing how to obtain IOPS thatsafunnyname/telegraf
2 participants
@thatsafunnyname @sjwang90