Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic in accumulator if nil is passed as the third parameter to Add #289

Closed
gotyaoi opened this issue Oct 19, 2015 · 3 comments
Closed

panic in accumulator if nil is passed as the third parameter to Add #289

gotyaoi opened this issue Oct 19, 2015 · 3 comments

Comments

@gotyaoi
Copy link
Contributor

gotyaoi commented Oct 19, 2015

I was testing the changes I had made for the config directory support when I came across this. The changes here: 6977119#diff-2df0b9f3bc0da3ee13966a69e386ff84R145 will panic if Add is passed nil as the tags parameter. A quick grep shows this only happens in the system plugin, the puppetagent plugin and as an example in the CONTRIBUTING.md file.

Edit: my grep was insufficient. This also occurs in the memory plugin, as it passes map[string]string(nil).

@sparrc
Copy link
Contributor

sparrc commented Oct 20, 2015

I'm working on overhauling the accumulator and already have a fix for this in that branch

@gotyaoi
Copy link
Contributor Author

gotyaoi commented Oct 20, 2015

Ok, cool.

@gotyaoi gotyaoi closed this as completed Oct 20, 2015
@sparrc
Copy link
Contributor

sparrc commented Oct 20, 2015

I'll leave this case open until I actually get that pushed, thanks for the report @gotyaoi!

@sparrc sparrc reopened this Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
sparrc added a commit that referenced this issue Oct 20, 2015
@sparrc sparrc closed this as completed in c26ce9c Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants