Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpjson: support configurable response_timeout #1650

Closed
gam-phon opened this issue Aug 18, 2016 · 2 comments
Closed

httpjson: support configurable response_timeout #1650

gam-phon opened this issue Aug 18, 2016 · 2 comments

Comments

@gam-phon
Copy link
Contributor

gam-phon commented Aug 18, 2016

There is no configurable response_timeout in httpjson input. I have an endpoint that takes more than the default timeout to response.

Here is the default response_timeout, which is hard coded, for httpjson:

        tr := &http.Transport{
            ResponseHeaderTimeout: time.Duration(3 * time.Second),
            TLSClientConfig:       tlsCfg,
        }
        client := &http.Client{
            Transport: tr,
            Timeout:   time.Duration(4 * time.Second),
        }
@gam-phon gam-phon changed the title httpjson: support configurable timeout httpjson: support configurable response_timeout Aug 18, 2016
@gam-phon
Copy link
Contributor Author

gam-phon commented Aug 18, 2016

I have opened a pull request to add this.

@sparrc
Copy link
Contributor

sparrc commented Aug 30, 2016

closed by #1651

@sparrc sparrc closed this as completed Aug 30, 2016
sparrc added a commit that referenced this issue Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants