Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket_listener: silence health checks in logs #13043

Closed
phemmer opened this issue Apr 6, 2023 · 1 comment · Fixed by #13288
Closed

socket_listener: silence health checks in logs #13043

phemmer opened this issue Apr 6, 2023 · 1 comment · Fixed by #13288
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@phemmer
Copy link
Contributor

phemmer commented Apr 6, 2023 •
edited
Loading

Use Case

Right now the socket_listener input generates lots of noise due to health check probes. For example if you have a load balancer which opens a tcp socket to the input, and then closes the socket without writing anything (after completing SSL handshake), it generates 2 logs entries (in the case of SSL):

Apr 06 03:56:36 myhost telegraf[21963]: 2023-04-06T03:56:36Z E! [inputs.socket_listener] Error in plugin: connection not a TCP connection (*tls.Conn)
Apr 06 03:56:36 myhost telegraf[21963]: 2023-04-06T03:56:36Z E! [inputs.socket_listener] Error in plugin: creating decoder failed: write tcp 10.0.0.10:8085->10.0.2.9:33288: write: connection reset by peer

When you have many clients, this gets extremely noisy and make it hard to observe the logs for meaningful information.

Expected behavior

Silence

Actual behavior

Apr 06 03:56:36 myhost telegraf[21963]: 2023-04-06T03:56:36Z E! [inputs.socket_listener] Error in plugin: connection not a TCP connection (*tls.Conn)
Apr 06 03:56:36 myhost telegraf[21963]: 2023-04-06T03:56:36Z E! [inputs.socket_listener] Error in plugin: creating decoder failed: write tcp 10.0.0.10:8085->10.0.2.9:33288: write: connection reset by peer

Additional info

No response
@phemmer phemmer added the feature request Requests for new plugin and for new features to existing plugins label Apr 6, 2023
phemmer added a commit to phemmer/telegraf that referenced this issue Apr 7, 2023
@phemmer
fix(inputs.socket_listener): fix noisy logs on closed connection
731aae4 
This suppresses several different logs that may be emitted when the connection is closed (locally or by remote) at various points.

Fixes influxdata#13043
@phemmer phemmer mentioned this issue Apr 7, 2023
Closed
3 tasks
phemmer added a commit to phemmer/telegraf that referenced this issue Apr 7, 2023
@phemmer
fix(inputs.socket_listener): fix noisy logs on closed connection
160fd34 
This suppresses several different logs that may be emitted when the connection is closed (locally or by remote) at various points.

Fixes influxdata#13043
@powersj
Copy link
Contributor

powersj commented Apr 13, 2023

next steps: finish reviews of #13060

@srebhan srebhan mentioned this issue May 19, 2023
Merged
srebhan pushed a commit to srebhan/telegraf that referenced this issue May 19, 2023
@phemmer @srebhan
fix(inputs.socket_listener): fix noisy logs on closed connection
222bfcb 
This suppresses several different logs that may be emitted when the connection is closed (locally or by remote) at various points.

Fixes influxdata#13043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Milestone
No milestone
2 participants
@phemmer @powersj