Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlserver: Completing Query Store related Performance counters #10855

Closed
dba-leshop opened this issue Mar 21, 2022 · 2 comments · Fixed by #11216
Closed

sqlserver: Completing Query Store related Performance counters #10855

dba-leshop opened this issue Mar 21, 2022 · 2 comments · Fixed by #11216
Labels
area/sqlserver feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution

Comments

@dba-leshop
Copy link
Contributor

dba-leshop commented Mar 21, 2022

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

Adding following performance counters:

  • Query Store logical reads
  • Query Store logical writes
  • Query Store physical reads

Cf. Microsoft Docs

Current behavior:

Currently, only Query Store CPU usage is included to performance counter query.

Desired behavior:

Getting additional Query Store IO related performance counters

Use case:

To enhance Query Store usage monitoring

@dba-leshop dba-leshop added the feature request Requests for new plugin and for new features to existing plugins label Mar 21, 2022
@sspaink
Copy link
Contributor

sspaink commented May 12, 2022

This seems like it could be a good addition to the sqlserver, I assume it could be as easy as extending this select statement: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sqlserver/sqlserverqueries.go#L416 to get the additional counters?

@dba-leshop would you be interested in perhaps creating a pull request implementing this change?

@sspaink sspaink added the help wanted Request for community participation, code, contribution label May 12, 2022
@dba-leshop
Copy link
Contributor Author

@sspaink Sure. I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feature request Requests for new plugin and for new features to existing plugins help wanted Request for community participation, code, contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants