Skip to content

Commit

Permalink
Respect path prefix in influx output uri (#3224)
Browse files Browse the repository at this point in the history
(cherry picked from commit 9c8f4af)
  • Loading branch information
dimrozakis authored and danielnelson committed Oct 18, 2017
1 parent 7b8a761 commit c4cc579
Show file tree
Hide file tree
Showing 5 changed files with 48 additions and 13 deletions.
4 changes: 1 addition & 3 deletions etc/telegraf.conf
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@

# Configuration for influxdb server to send metrics to
[[outputs.influxdb]]
## The HTTP or UDP URL for your InfluxDB instance. Each item should be
## of the form:
## scheme "://" host [ ":" port]
## The full HTTP or UDP URL for your InfluxDB instance.
##
## Multiple urls can be specified as part of the same cluster,
## this means that only ONE of the urls will be written to each interval.
Expand Down
4 changes: 1 addition & 3 deletions plugins/outputs/influxdb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ This plugin writes to [InfluxDB](https://www.influxdb.com) via HTTP or UDP.
```toml
# Configuration for influxdb server to send metrics to
[[outputs.influxdb]]
## The HTTP or UDP URL for your InfluxDB instance. Each item should be
## of the form:
## scheme "://" host [ ":" port]
## The full HTTP or UDP URL for your InfluxDB instance.
##
## Multiple urls can be specified as part of the same cluster,
## this means that only ONE of the urls will be written to each interval.
Expand Down
15 changes: 11 additions & 4 deletions plugins/outputs/influxdb/client/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"io/ioutil"
"net/http"
"net/url"
"path"
"time"
)

Expand Down Expand Up @@ -255,15 +256,21 @@ func writeURL(u *url.URL, wp WriteParams) string {
}

u.RawQuery = params.Encode()
u.Path = "write"
return u.String()
p := u.Path
u.Path = path.Join(p, "write")
s := u.String()
u.Path = p
return s
}

func queryURL(u *url.URL, command string) string {
params := url.Values{}
params.Set("q", command)

u.RawQuery = params.Encode()
u.Path = "query"
return u.String()
p := u.Path
u.Path = path.Join(p, "query")
s := u.String()
u.Path = p
return s
}
34 changes: 34 additions & 0 deletions plugins/outputs/influxdb/client/http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,3 +299,37 @@ func TestGzipCompression(t *testing.T) {

assert.Equal(t, []byte(influxLine), uncompressed.Bytes())
}

func TestHTTPClient_PathPrefix(t *testing.T) {
prefix := "/some/random/prefix"
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
case prefix + "/write":
w.WriteHeader(http.StatusNoContent)
w.Header().Set("Content-Type", "application/json")
case prefix + "/query":
w.WriteHeader(http.StatusOK)
w.Header().Set("Content-Type", "application/json")
fmt.Fprintln(w, `{"results":[{}]}`)
default:
w.WriteHeader(http.StatusNotFound)
msg := fmt.Sprintf("Path not found: %s", r.URL.Path)
fmt.Fprintln(w, msg)
}
}))
defer ts.Close()

config := HTTPConfig{
URL: ts.URL + prefix,
}
wp := WriteParams{
Database: "test",
}
client, err := NewHTTP(config, wp)
defer client.Close()
assert.NoError(t, err)
err = client.Query("CREATE DATABASE test")
assert.NoError(t, err)
err = client.WriteStream(bytes.NewReader([]byte("cpu value=99\n")))
assert.NoError(t, err)
}
4 changes: 1 addition & 3 deletions plugins/outputs/influxdb/influxdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,7 @@ type InfluxDB struct {
}

var sampleConfig = `
## The HTTP or UDP URL for your InfluxDB instance. Each item should be
## of the form:
## scheme "://" host [ ":" port]
## The full HTTP or UDP URL for your InfluxDB instance.
##
## Multiple urls can be specified as part of the same cluster,
## this means that only ONE of the urls will be written to each interval.
Expand Down

0 comments on commit c4cc579

Please sign in to comment.