Skip to content

Commit

Permalink
test: switch internet speed to enable file download
Browse files Browse the repository at this point in the history
The file download test when enabled is significantly faster in terms of
total test time (45 sec vs 4 sec). In CI when running all these tests
in parallel we could hit limits or timeouts, so we want to limit our
need for external networking.

Running with the previous setting, while running other integration tests
can lead to timeouts and other networking hickups, which cause this test
to fail.

fixes: #11123
  • Loading branch information
powersj committed May 19, 2022
1 parent dad330c commit 2f372e3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugins/inputs/internet_speed/internet_speed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ func TestGathering(t *testing.T) {
t.Skip("Skipping network-dependent test in short mode.")
}
internetSpeed := &InternetSpeed{
EnableFileDownload: false,
EnableFileDownload: true,
Log: testutil.Logger{},
}

Expand All @@ -26,7 +26,7 @@ func TestDataGen(t *testing.T) {
t.Skip("Skipping network-dependent test in short mode.")
}
internetSpeed := &InternetSpeed{
EnableFileDownload: false,
EnableFileDownload: true,
Log: testutil.Logger{},
}

Expand Down

0 comments on commit 2f372e3

Please sign in to comment.