Rebase to nxadm #12
Draft
Rebase to nxadm #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* http://gopkg.in/fsnotify/fsnotify.v1 is the new location * see: https://github.com/go-fsnotify/fsnotify
Fix fsnotify repository relocation
* update and complete documentation * small linter fixes
FreeBSD CI support
Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.4.9 to 1.5.1. - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/master/CHANGELOG.md) - [Commits](fsnotify/fsnotify@v1.4.9...v1.5.1) --- updated-dependencies: - dependency-name: github.com/fsnotify/fsnotify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use temp directory for tests, instead of relative Since the Go module cache is read-only by default, modifications in the module directory cause failures for dependents running `go test all`. * Make test dir cleanup Go 1.14-friendly * Make test dir cleanup Go 1.11-friendly Co-authored-by: nxadm <[email protected]>
* Add timeouts to tests * apparently 30s was too ambitious
* first draft of CompleteLines * tests * refactor * CompleteLines should return the last line if we don't follow * rename temp dirs to avoid races * Conditional allocation of strings.Builder * Fix tests by using the new cleanup() Co-authored-by: nxadm <[email protected]>
...otherwise we can run into the scenario where: On start we read the contents of the file, we hit EOF, and start watching for changes. But in between the EOF and start watching, the file is updated. But since the watcher wasn't started, we don't notice.
At least on FreeBSD 11.1-STABLE amd64 it fails otherwise...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.