feat: add feature emit_fields
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would be better exposed as a config option on pbjson-build in the same manner as ignore-unknown-fields. The additive behaviour of cargo feature flags could easily result in surprises otherwise. If we could also test it in a similar way, that would be awesome. See #36 for reference |
|
ok |
tustvold
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
This looks good to me.
One thing I noticed whilst playing around with this is it will not emit nullable fields, i.e. messages or fields explicitly marked optional. I think this is fine as "default" in protobuf normally refers to fields where there is a default value instead of nullability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developers.google.com/protocol-buffers/docs/proto3#json_options