correctness fixes to get Envoy xDS protos compiling #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Feb 13, 2022
There was a problem hiding this comment.
I am so sorry for missing this and not reviewing this sooner, thank you for this contribution 👍
I left a minor nit, which you can take or leave, just let me know.
If you could please sign the CLA, I can get this in. It's pretty boilerplate, but let me know if there are any issues.
| @@ -57,7 +58,7 @@ impl<'a> Resolver<'a> { | |||
| .path() | |||
| .iter() | |||
| .zip(path.path()) | |||
| .filter(|(a, b)| a == b) | |||
| .take_while(|(a, b)| a == b) | |||
tustvold
reviewed
Feb 13, 2022
| .filter(|variant| { | ||
| // Skip duplicate enum values. Protobuf allows this when the | ||
| // 'allow_alias' option is set. | ||
| numbers.insert(variant.number()) |
There was a problem hiding this comment.
Perhaps we could get a test of this added to pbjson-test?
|
Hi! Is there any news about this PR? |
Co-authored-by: Raphael Taylor-Davies <[email protected]>
|
I've started working on it. |
|
Closed by #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏻 I'm working to read in some Envoy protobufs, and its a large project with a bunch of corner cases (e.g. fields named
map, enum values namedselfand with theallow_aliasoption enabled, etc). The below commits are what I needed to get things at least compiling!