Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add guards against using secrets in forked PR builds #20506

Merged
merged 4 commits into from
Jan 13, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #20505

Follows the instructions described in this blog post from the CircleCI team.

@danxmoran
Copy link
Contributor Author

Hold off on review for now, we might be able to make the grace & litmus images public instead

@danxmoran danxmoran marked this pull request as draft January 13, 2021 16:12
@danxmoran danxmoran marked this pull request as ready for review January 13, 2021 17:17
@danxmoran danxmoran force-pushed the dm-ci-from-forks-20505 branch from e3f142b to 5aa1f6d Compare January 13, 2021 17:20
@psteinbachs psteinbachs self-requested a review January 13, 2021 17:21
Copy link
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've agreed to do this as an intermediate workaround while we get our ducks in a row regarding the grace repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI can never pass on PRs from forks
2 participants