feat: aggregate array cursors #19813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpacik
commented
Oct 23, 2020
| return nil | ||
| } | ||
|
|
||
| func newSumArrayCursor(cur cursors.Cursor) cursors.Cursor { |
There was a problem hiding this comment.
This is subsumed by WindowAggregateArrayCursor now.
jpacik
commented
Oct 23, 2020
| } | ||
| } | ||
|
|
||
| func newCountArrayCursor(cur cursors.Cursor) cursors.Cursor { |
There was a problem hiding this comment.
This is also subsumed by WindowAggregateArrayCursor now.
jpacik
commented
Oct 23, 2020
| @@ -38,131 +51,16 @@ func newWindowAggregateArrayCursor(ctx context.Context, agg *datatypes.Aggregate | |||
| } | |||
| } | |||
|
|
|||
| type arrayCursors struct { | |||
There was a problem hiding this comment.
This isn't used at all. OSS uses multiShardArrayCursors which is almost identical in structure except for the underlying series cursor.
jpacik
commented
Oct 23, 2020
Comment on lines
54
to
+63
| type cursorContext struct { | ||
| ctx context.Context | ||
| req *cursors.CursorRequest | ||
| itrs cursors.CursorIterators | ||
| limit int64 | ||
| count int64 | ||
| err error | ||
| ctx context.Context | ||
| req *cursors.CursorRequest | ||
| itrs cursors.CursorIterators | ||
| err error | ||
| } | ||
|
|
||
| type multiShardArrayCursors struct { | ||
| ctx context.Context | ||
| limit int64 | ||
| req cursors.CursorRequest | ||
| ctx context.Context | ||
| req cursors.CursorRequest |
There was a problem hiding this comment.
Aggregation is now handled by WindowAggregateArrayCursor, so there's no need to calculate summary stats like count and limit here.
jpacik
requested review from
a team and
jsternberg
and removed request for
a team
jsternberg
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.