feat(query): add a feature flag for query tracing #19437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffcm
changed the title
wolffcm
force-pushed
the
feat/query-tracing-feature-flag
branch
from
eaeba89 to
79cb1fd
Compare
wolffcm
force-pushed
the
feat/query-tracing-feature-flag
branch
from
79cb1fd to
f3b8d6d
Compare
wolffcm
requested review from
a team and
ethanyzhang
and removed request for
a team
ethanyzhang
approved these changes
Aug 26, 2020
flags.yml
Outdated
| @@ -83,6 +83,13 @@ | |||
| contact: Query Team | |||
| lifetime: temporary | |||
|
|
|||
| - name: Experimental Query Tracing | |||
There was a problem hiding this comment.
With this being a permanent flag, I think we can just call this query tracing, leaving out "experimental"? What do you think?
wolffcm
pushed a commit
that referenced
this pull request
Sep 10, 2020
I reapplied this via cherry-pick after it was reverted by the OSS storage split.
wolffcm
pushed a commit
that referenced
this pull request
Sep 16, 2020
I reapplied this via cherry-pick after it was reverted by the OSS storage split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16220.
This adds a feature flag for experimental query tracing, which creates a span for each source and transformation in query requests.